upcoming: [DI-25634] - Added linode_id to label translation in cloudpulse graph#12558
Conversation
nikhagra-akamai
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
| --- | ||
| "@linode/manager": Changed | ||
| --- | ||
|
|
||
| ACLP: add `regionId` prop to `filter region scope` alerts, add `isLegacyAlertAvailable` to `show confirmation dialog on save of alerts`, add logic to `hide manage alert button` in `AlertReusableComponent` ([#12558](https://github.com/linode/manager/pull/12558)) |
There was a problem hiding this comment.
Let's remove this changeset now. See #12577 (comment) and d83a275.
There was a problem hiding this comment.
At first glance, it looks like this will only support Linodes using config profile network interfaces. Should we support the firewall device entity type of linode_interface?
There was a problem hiding this comment.
Also, do we need to support NodeBalancers?
There was a problem hiding this comment.
Yes currently it is only linodes only and not for nodebalancers. There's not plan as for now for NB
There was a problem hiding this comment.
@nikhagra-akamai what about his question?
Should we support the firewall device entity type of linode_interface?
There was a problem hiding this comment.
Just confirmed with Kiran, we are only translating linode and not linode_interface
…gra-akamai/manager into metric/linode-id-label-translation
Cloud Manager UI test results🔺 1 failing test on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
7 participants
Description 📝
Translating linode id coming as part of metrics API response is translated for corresponding linode label
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
12th August
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
CloudPulseDashboard.tsxfile, at line 90, pass 'firewall' as service typeAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅